Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate site manifest and favicons to Hugo Pipes #720

Open
jpanther opened this issue Nov 25, 2023 · 2 comments
Open

Migrate site manifest and favicons to Hugo Pipes #720

jpanther opened this issue Nov 25, 2023 · 2 comments
Labels
enhancement New feature or request help wanted Community submissions are encouraged

Comments

@jpanther
Copy link
Owner

This is a placeholder issue for reimplementing the site manifest and favicons functionality to use Hugo Pipes. It aims to address a number of discussions: #372, #682, #683, #711 and #713.

High level overview of the changes required:

  • Remove all the static files
  • Generate site manifest and favicons using Hugo Pipes
  • Allow for favicons to be disabled
  • Theme the favicons to match the selected colour scheme
  • Better documentation around how this feature works

Potentially useful reference material: https://dev.to/masakudamatsu/favicon-nightmare-how-to-maintain-sanity-3al7

Any other suggestions?

@jpanther jpanther added enhancement New feature or request help wanted Community submissions are encouraged labels Nov 25, 2023
@wolfspyre
Copy link
Contributor

good call @jpanther

I'm working on getting this cobbled together adjacent...

It may become a PR, or may serve as inspiration for others:

https://gitlab.wolfspyre.io/wolfspyrelabs/hugo-kisso/wplshortcodes/-/blob/wpl_main/layouts/_default/home.manifest.webmanifest?ref_type=heads

(or motivation around what not to do? :) )

Copy link

This issue has been automatically marked as stale because it has not had any recent activity.
If you are still experiencing this issue, please review the issue history and add a reply with any requested and/or additional information in order to keep the issue open.
This issue will automatically close in 30 days if no further activity occurs.

@github-actions github-actions bot added the stale This issue or pull request has not had any recent activity label Mar 25, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 24, 2024
@jpanther jpanther removed the stale This issue or pull request has not had any recent activity label Apr 29, 2024
@jpanther jpanther reopened this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Community submissions are encouraged
Projects
None yet
Development

No branches or pull requests

2 participants