Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close menu button on click #705

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

Jh123x
Copy link
Contributor

@Jh123x Jh123x commented Nov 12, 2023

  • fix: close menu on click

Closes #460

Copy link

netlify bot commented Nov 12, 2023

Deploy Preview for hugo-congo ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2ca6096
🔍 Latest deploy log https://app.netlify.com/sites/hugo-congo/deploys/6563610b9cdf5f00080a2f7a
😎 Deploy Preview https://deploy-preview-705--hugo-congo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jh123x Jh123x force-pushed the fix/460/close-menu-on-site-click branch from c6658ea to a785bb0 Compare November 12, 2023 11:46
@jpanther
Copy link
Owner

While this does solve the original issue, it introduces a new one in that this will violate content security policies that don't allow unsafe inline scripts. The way this needs to be implemented is by including this in an external script and then referencing the function from there.

@jpanther
Copy link
Owner

Thanks, that change addresses the inline issue. I think we should also duplicate this into the hybrid header too otherwise the behaviour won't be consistent between header layouts.

@jpanther jpanther added the bug Something isn't working label Nov 25, 2023
@jpanther
Copy link
Owner

Thanks for the update, I'll merge this one in later today.

@jpanther jpanther merged commit e0aae4f into jpanther:dev Nov 27, 2023
6 checks passed
@Jh123x Jh123x deleted the fix/460/close-menu-on-site-click branch November 27, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menu is not closing for one-page site
2 participants