Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add share options #719

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Conversation

Jh123x
Copy link
Contributor

@Jh123x Jh123x commented Nov 25, 2023

Changelog:

  1. Add telegram sharing option
  2. Add line sharing option

No changes to color is allowed based on their official website
https://line.me/en/logo
Copy link

netlify bot commented Nov 25, 2023

Deploy Preview for hugo-congo ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 763257a
🔍 Latest deploy log https://app.netlify.com/sites/hugo-congo/deploys/656363f298492d0008d9928a
😎 Deploy Preview https://deploy-preview-719--hugo-congo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jpanther jpanther added the enhancement New feature or request label Nov 25, 2023
@jpanther
Copy link
Owner

jpanther commented Nov 25, 2023

I'm happy to add this functionality however this PR needs a couple of changes:

  • Change the Line SVG to use the icon from FontAwesome (and modify the asset to match the existing SVGs in the theme in terms of structure and adding fill="currentColor" to the path so it is themed correctly)
  • Add the required i18n strings for sharing.telegram and sharing.line (including placeholders in all the languages other than English, as required)

@github-actions github-actions bot added the i18n Issue with i18n translations label Nov 26, 2023
@jpanther
Copy link
Owner

Wow, you really went above and beyond with the i18n strings. I was only expecting blank commented out placeholders but you've managed to actually translate them all! I'm happy to merge this one in. I'll get to it later today.

@jpanther jpanther merged commit b0be87c into jpanther:dev Nov 27, 2023
6 checks passed
@Jh123x Jh123x deleted the feat/more-share-options branch November 27, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request i18n Issue with i18n translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants