Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mkt_tok marketing tokens #24

Merged
merged 1 commit into from
Feb 25, 2019
Merged

Conversation

Seanstoppable
Copy link
Contributor

No description provided.

@jparise jparise merged commit 0436417 into jparise:master Feb 25, 2019
@jparise
Copy link
Owner

jparise commented Feb 25, 2019

Looks good. Thanks, @Seanstoppable!

@fmarier
Copy link

fmarier commented Jun 26, 2020

By the way, the mkt_tok parameter is actually required for unsubscribe links to work: brave/brave-browser#9018 (comment)

@jparise
Copy link
Owner

jparise commented Aug 16, 2020

@fmarier I haven't seen any recent updates to the linked issue. Were you able to determine if removing this token merely makes the unsubscribe process less convenient (by not prefilling the email address) or if it prevents unsubscribing entirely?

@fmarier
Copy link

fmarier commented Aug 18, 2020

Were you able to determine if removing this token merely makes the unsubscribe process less convenient (by not prefilling the email address) or if it prevents unsubscribing entirely?

No, I don't have enough visibility over the backend to be able to know for sure, though having to type an email address manually also makes for a bad user experience and so I'm planning to exempt these unsubscribe requests from the filter built into Brave.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants