Rework encode()'s error handling #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jparise
force-pushed
the
encode-errors
branch
2 times, most recently
from
332e432
to
9f5cae9
Compare
We no longer use a regular expression to validate the input string. Instead, the logic within the per-character encoding loop has been improved to catch all of the known error cases and raise appropriate ValueError exceptions. This results in slightly faster code with more useful errors. For example, we now include the actual character that we've identified as invalid, which aids in debugging.
jparise
force-pushed
the
encode-errors
branch
from
9f5cae9
to
c944022
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer use a regular expression to validate the input string.
Instead, the logic within the per-character encoding loop has been
improved to catch all of the known error cases and raise appropriate
ValueErrorexceptions.One notable behavioral change: we now raise an error for unsupported
character codes within the 0..69 range.
This results in slightly faster code with more useful errors. For
example, we now include the actual character that we've identified as
invalid, which aids in debugging.