Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: infinite query for products list #9

Merged
merged 4 commits into from
Nov 26, 2022
Merged

chore: infinite query for products list #9

merged 4 commits into from
Nov 26, 2022

Conversation

jpb06
Copy link
Owner

@jpb06 jpb06 commented Nov 26, 2022

No description provided.

@vercel
Copy link

vercel bot commented Nov 26, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
graphql-shop ✅ Ready (Inspect) Visit Preview Nov 26, 2022 at 5:50AM (UTC)

@jpb06
Copy link
Owner Author

jpb06 commented Nov 26, 2022 •
edited
Loading

dotansimha/graphql-code-generator#8567 (comment)

Manually removing useless infinite queries and using the following impl:

(metaData) => query({ ...variables, ...(metaData.pageParam ?? {}) }),

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jpb06 jpb06 merged commit 258a3f9 into main Nov 26, 2022
@jpb06 jpb06 deleted the inifinite-query branch November 26, 2022 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jpb06