Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate function and use a request class for params #138

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

jpbede
Copy link
Owner

@jpbede jpbede commented Mar 6, 2024

No description provided.

@jpbede jpbede added enhancement Enhancement of the code, not introducing new features. breaking-change A breaking change for existing users. labels Mar 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9ef1b18) to head (a15fa45).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #138   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         6    +1     
  Lines          109       124   +15     
  Branches        15        19    +4     
=========================================
+ Hits           109       124   +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpbede jpbede merged commit f9da76e into main Mar 6, 2024
17 checks passed
@jpbede jpbede deleted the remove-function-duplication branch March 6, 2024 18:41
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change A breaking change for existing users. enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant