Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate current and legacy endpoint to new one #90

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

jpbede
Copy link
Owner

@jpbede jpbede commented Jan 30, 2024

Migrate the current and the legacy co2signal endpoint to the new one.
This way we can get rid of the second call to try the legacy api

@jpbede jpbede added enhancement Enhancement of the code, not introducing new features. minor This PR causes a minor version bump in the version number. labels Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c3522c5) 89.83% compared to head (90033bd) 96.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
+ Coverage   89.83%   96.66%   +6.83%     
==========================================
  Files           6        5       -1     
  Lines         118       90      -28     
  Branches       17       12       -5     
==========================================
- Hits          106       87      -19     
+ Misses          8        1       -7     
+ Partials        4        2       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpbede jpbede merged commit 769b5ae into main Jan 30, 2024
17 checks passed
@jpbede jpbede deleted the migrate-to-new-endpoint branch January 30, 2024 15:19
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhancement of the code, not introducing new features. minor This PR causes a minor version bump in the version number.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant