Code

Fixes of Quads and NGons.#138

Code

Open

mifth wants to merge 17 commits intojpcy:masterjpcy/xatlas:masterfrom mifth:mastermifth/xatlas_fixes:masterCopy head branch name to clipboard

+213-33

Commits

Commits on Oct 27, 2024

• Fixes for Quads and NGons.

  mifth

  committed
  e74bbbc

  Copy full SHA for e74bbbc

• Removed an empty line

  mifth

  committed
  83c6c45

  Copy full SHA for 83c6c45

Commits on Oct 28, 2024

• Set faceVertexCount=uint32_t as potentially NGon can have 1000000 indices.

  mifth

  committed
  69b139d

  Copy full SHA for 69b139d

Commits on Oct 29, 2024

• The indicesIDs array is moved to the Triangulated struct and has a reserve() line.

  mifth

  committed
  45d673c

  Copy full SHA for 45d673c

• Fix for a zero area calculation for NGons. jpcy#135 (comment)

  mifth

  committed
  0a96bd1

  Copy full SHA for 0a96bd1

• fix: initialised "area" variable.

  mifth

  committed
  710357a

  Copy full SHA for 710357a

Commits on Nov 4, 2024

• Final changes for Quads and NGons. computeBoundaryIntersection variable is added to ChartOptions.

  mifth

  committed
  22f4d64

  Copy full SHA for 22f4d64

Commits on Nov 5, 2024

• Fixed typo

  mifth

  committed
  c4703c5

  Copy full SHA for c4703c5

• Removed computeBoundingIntersection variable. Fixed quads/ngons for patches.

  mifth

  committed
  f01768a

  Copy full SHA for f01768a

Commits on Nov 6, 2024

• Delete unneeded check.

  mifth

  committed
  2d44719

  Copy full SHA for 2d44719

Commits on Nov 7, 2024

• Reverted "#IF 0" as it will be as a different PR. Little tweaks.

  mifth

  committed
  5ac6a5d

  Copy full SHA for 5ac6a5d

• Cleanup.

  mifth

  committed
  49ce073

  Copy full SHA for 49ce073

• Wrong number for a quad.

  mifth

  committed
  98806d6

  Copy full SHA for 98806d6

Commits on Nov 8, 2024

• Commented a simple case for "quads to triangles". But I would like to leave it commented to make an option in future.

  mifth

  committed
  15a9d20

  Copy full SHA for 15a9d20

• PiecewiseParam::computeChart() function still does artifacts for Quads/NGons and I wasn't be able to fix it. So I commented my fixes in the PiecewiseParam::computeChart() function and set "m_isInva…

  Show description for 2f47d81
  mifth

  committed
  2f47d81

  Copy full SHA for 2f47d81

• Uncommented code for the PiecewiseParam::computeChart() as it's needed for flipped faces and zero faces.

  mifth

  committed
  a4bb139

  Copy full SHA for a4bb139

• Missed vertices are added.

  mifth

  committed
  d92f849

  Copy full SHA for d92f849