Only convert request payloads to JSON a single time #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh good catch! Thanks for the fix - I'll try to get a new release out today! |
|
This is now live on pip as version Thanks again for the fix! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
BaseClient._call_raw()method currently catchesHubspotUnauthorizederrors, and then recursively calls itself after refreshing the OAuth2 tokens. This results inBaseClient._prepare_request()being called a second time which results injson.dumps()being called on the data payload twice. A payload like{"a": 1}then becomes"{\"a\":1}"and the Hubspot API can't successfully parse the content.This PR passes the
retriedparameter intoBaseClient._prepare_request()and skips thejson.dumps()step for requests that are being retried.