Prevent duplicated querystring parameters when getting batches of contacts #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ContactsClient.get_batch()
method was mutating theContactsClient.default_batch_properties
when adding in theextra_properties
. This resulted in a situation where subsequent calls toContactsClient.get_batch()
would causeproperty=X
to be repeated once for each time it had been included previously. This eventually leads to a bad request error from Hubspot once the URI gets too long.This PR stops the
ContactsClient.default_batch_properties
mutation from happening, and uses a set instead of a list so that there won't be duplicate properties in the query string even if they appear in bothextra_properties
andContactsClient.default_batch_properties
.