Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update method in Tickets API now parses data dict into a list of dicts #81

Merged

Conversation

selinfildis
Copy link
Contributor

@selinfildis selinfildis commented Jan 3, 2020

Update method in Tickets API didn't parse dict therefore the user needed to send a list of dicts, now it parses the dict. Also added tests for update ticket method.

related comment in TicketAPI issue: #29 (comment)
@vivithemage can you please also take a look 👼

@vivithemage
Copy link
Contributor

Just tried the changes and the admin panel and looks good on my end.

params = {
    "hs_ticket_priority": "LOW",
    "content": "hi there"
}

""" List all tickets """
ticket_client = TicketsClient(api_key=API_KEY)
ticket_client.update(ticket_id="73420176", data=params)

@jpetrucciani
Copy link
Owner

Cool! If it works for you two, I'll get that merged in now.

Thanks for the contribution!

@jpetrucciani jpetrucciani merged commit a124123 into jpetrucciani:master Jan 5, 2020
@jpetrucciani
Copy link
Owner

This is now live on pip as version 3.2.42

Thanks again for your contribution! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants