Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_recently_modified method to EngagementsClient class #94

Merged
merged 5 commits into from
Mar 20, 2020
Merged

Add get_recently_modified method to EngagementsClient class #94

merged 5 commits into from
Mar 20, 2020

Conversation

clivecorbishley
Copy link
Contributor

We found this client library to be super useful with quick access to the HubSpot API. We did need access to recent engagements as per this endpoint: https://developers.hubspot.com/docs/methods/engagements/get-recent-engagements

We were able to quickly replicate this successfuly by cloning and tweaking the get_all method.

It is worth noting that this method takes a timestamp (in milliseconds, just like Hubspot).

I am also happy to assist with documentation of this or testing.

@clivecorbishley clivecorbishley changed the title Add get_recent method to EngagementsClient class Add get_recently_modified method to EngagementsClient class Mar 19, 2020
@jpetrucciani
Copy link
Owner

I'm glad you've found it useful! 😄

Thanks for your contribution - I'll get that merged + released soon

@jpetrucciani jpetrucciani merged commit ce79220 into jpetrucciani:master Mar 20, 2020
@jpetrucciani
Copy link
Owner

This is now live on pip as version 3.2.47

Thanks again for your contribution! 😄

@clivecorbishley
Copy link
Contributor Author

Great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants