-
Notifications
You must be signed in to change notification settings - Fork 440
Feature/Discussion: Scopes #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anther
wants to merge
34
commits into
jpfuentes2:master
Choose a base branch
from
anther:scopes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
75e4a1e
Added Query class for chain sql queries
CarlosBonetti 7b032ab
Added support to custom scopes
CarlosBonetti ef95e1e
Added support to multiple wheres in a query
CarlosBonetti e6e6fc4
initial scope structure, going to merge with the query builder
anther 4589c66
added calls to scopes within Model
anther f07dd35
added ability to call named scopes statically
anther 82afd93
Bug fixes for finders
anther 76973e6
Added documentation all around the usage of named parameters, Fixed b…
anther 3756dac
Updated scopes to use static variables as opposed to function calls, …
anther 2ea8a54
Fixed bugs for where the static scopes were not declared
anther 70a969e
Added test to see if scopes worked through relations
anther b845ea3
Fixed bug with default scopes and for the base case of a ::scoped() b…
anther f70f885
Updated scopes to be able to call scopes on an object instance
anther 9ba4680
Fixed bug where Query.php did not generate a an "IS NULL" query corre…
anther 9f0f4a0
Bug fix to make sure NULL is not included as an anonymous parameter
anther 474deeb
Made count() work within a scope context
anther 3a44557
Added failing test to scopes
anther c162c2c
Made sure scope always returns an instance of Scope
anther fdbc957
Added exists function to scopes
anther 960fa7c
Bug fixes, completely separated scope of OptionBinder and Scope
anther c84af0a
Changes to make all previous tests pass
anther 8ef0ded
Set ActiveRecord.php back to its base state
anther fa1d4b9
Removed frivilous include
anther abb66b3
Fix for models that have no default scope
anther 310c695
Fixed misplaced comment and removed no longer used method
anther ee057b8
Added ability for a scope to be used as an array
anther 26ae232
Added functionality for generically appending scope calls similar to …
anther 421e2d4
Added test for appending joins to eachother
anther cf26638
Fixed bug where WHERE conditions were duplicated
anther e804f9b
added extra comment
anther d884c6a
fixed bug that would result in foreach not working on a scope
anther 1c3e1eb
Added countable interface to scope
anther 242c912
Added arrayaccess to scopes
anther 041d765
Merge branch 'base' into scopes
anther File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using an include/require statement here seems dirty. Could we move it?