Allow custom setter methods to run for aliased attributes (fixes #350) #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic in the Model::__set() magic method allowed for either an aliased attribute *or* a custom setter, but not both. If a custom setter method was defined for an aliased attribute, then the attribute value would be set without going through the custom setter method. Changed the logic so that the _set() method first normalizes an aliased attribute into the real attribute name, then checks to see if an there is a custom setter method defined and runs it if it exists.
|
@cvanschalkwijk should I add this to #430? |
|
Yes, I think we should add it because it is a bug yet trivial to fix. |
|
I just added it under the mixed category. |
|
I'd notice, GitHub protects its content from being saved after a remote change has occurred. |
|
I thought it didn't email on edited comments? Maybe no one's ever edited my comment/description for me to see. |
|
closes #350 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic in the Model::__set() magic method allowed for either an aliased
attribute or a custom setter, but not both. If a custom setter method
was defined for an aliased attribute, then the attribute value would be
set without going through the custom setter method.
Changed the logic so that the _set() method first normalizes an
aliased attribute into the real attribute name, then checks to see if
an there is a custom setter method defined and runs it if it exists.