Move Report Viewer to vite #1029
Conversation
# Conflicts: # report-viewer/package-lock.json # report-viewer/package.json
|
@sebinside Could you test the report viewer for any bugs and issues with a few larger and real samples? |
tsaglam
added
enhancement
There was a problem hiding this comment.
Code looks good,
but I tried running it and when trying to load a report the error "Invalid JSON: [object Object],[object Object]" keeps poping up.
Also I think the README.md in /report-viewer ist not up to date anymore as the command "npm run serve" does not seem to be working.
|
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
First of all, good work, looks promising and is already near to being merged. I had a look at your changes and also tested the report viewer with real-world data consisting of 20,000 comparisons. Here are my findings:
✅ Report Viewer behaves as expected for common operations
✅ Using the zip drag n drop method works in development
✅ Using the zip drag n drop method works after build using vite preview
❌ Using the src/files method with the extracted content of the zip file works neither in dev nor after build. The XMLHttpRequest gets printed to the console together with the warning Unable to build comparison file. This behavior remains when using a different local server like npm http-server.
Please have a look at this remaining bug. Afterward, we can merge this PR. Thank you!
This PR moves the Report Viewer to vite. This includes