Fix comparison view not working in local mode #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsaglam
added
bug
…hub.com/jplag/JPlag into bug/report-viewer-local-comparison-view
TwoOfTwelve
reviewed
May 8, 2023
core/src/main/java/de/jplag/reporting/reportobject/ReportObjectFactory.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
sebinside
reviewed
May 9, 2023
| return Path.of(submissionToIdFunction.apply(submission), submissionToIdFunction.apply(submission)).toString(); | ||
| } | ||
| return Path.of(submissionToIdFunction.apply(submission), submission.getRoot().toPath().relativize(file.toPath()).toString()).toString(); | ||
| return new Match(FilePathUtil.getRelativeSubmissionPath(startOfFirst.getFile(), comparison.firstSubmission(), submissionToIdFunction), |
There was a problem hiding this comment.
This return really isn't that readable, and neither was the original one.
That's the only thing I found in my static code review, I will perform some runtime tests later.
|
I successfully tested the following:
|
sebinside
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comparison view of the report viewer was broken when using local mode.
To fix this I added the file
submissionFileIndex.jsonfile, which stores a map of submission IDs to all their submitted files, which now gets read when opening the comparison view.I also updated the wikis page about the report generation accordingly.