Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report viewer Auto lint check #1111

Merged
merged 7 commits into from
May 26, 2023
Merged

Report viewer Auto lint check #1111

merged 7 commits into from
May 26, 2023

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented May 26, 2023

This PR adds two new Workflows. One runs the eslint check, the other checks if all prettier rules where followed

@Kr0nox Kr0nox requested review from sebinside, dfuchss, TwoOfTwelve and a team May 26, 2023 10:43
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sebinside sebinside removed request for a team, sebinside and TwoOfTwelve May 26, 2023 11:05
@sebinside
Copy link
Member

@dfuchss knows best about workflows! 😄

dfuchss
dfuchss approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@dfuchss dfuchss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actions look good to me. Maybe simply test them on a temporary fork :)

@Kr0nox
Copy link
Member Author

Kr0nox commented May 26, 2023

Worked fine on the fork

@dfuchss dfuchss merged commit 0a84504 into develop May 26, 2023
@dfuchss dfuchss deleted the report-viewer/auto-lint-check branch May 26, 2023 13:21
@Kr0nox Kr0nox mentioned this pull request May 26, 2023
Closed
@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies labels Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfuchss dfuchss dfuchss approved these changes

Assignees
No one assigned
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kr0nox @sebinside @dfuchss @tsaglam