Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update eslint-vue and prevent reactivity loss of props #1262

Merged
merged 4 commits into from
Aug 31, 2023

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Aug 24, 2023

This PR updates the eslint vue plugin to the newest version.

It also enables the newly added rule to prevent reactivity loss through prop deconstrcution. This rule was implemneted in all places violating it

Replaces #1245

@Kr0nox
Copy link
Member Author

Kr0nox commented Aug 30, 2023

@sebinside In all PR i will need to merge develop into the branch once. Should I wait for your approval on all those PRs again or can I just merge them?

@sonarqubecloud
Copy link

[JPlag Report Viewer] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[JPlag Plagiarism Detector] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sebinside
Copy link
Member

@Kr0nox As all of these PRs don't change bigger parts of the logic, please just go ahead and merge the PRs, thank you.

@Kr0nox Kr0nox merged commit 2187ab7 into develop Aug 31, 2023
@Kr0nox Kr0nox deleted the report-viewer/prop-deconstruction branch August 31, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants