Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript language module #1494

Merged
merged 7 commits into from
Jan 26, 2024
Merged

JavaScript language module #1494

merged 7 commits into from
Jan 26, 2024

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Jan 20, 2024

Adds a language module for javascript.
It just extends TypeScript, since every typescript keyword is also a javascript keyword.

I moved the js specific tests from the ts language module to the js language module

@Kr0nox Kr0nox requested review from tsaglam and TwoOfTwelve January 20, 2024 20:36
@Kr0nox
Copy link
Member Author

Kr0nox commented Jan 22, 2024

@Kr0nox the language loader should check for language interface implementations, and thus the Javascript module should be mentioned when the dependency in the CLI module ist set...

The Language Loader currently uses the getName method of a Language. Currently this returns the Parser for every language. As you mentioned it should mention the javascript method, but the parser still is the typescript parser.
@tsaglam How do you want that handled?

@tsaglam
Copy link
Member

tsaglam commented Jan 22, 2024

I would say this is an internal detail that is not important for users. So it is fine when it says javascript for now...

@Kr0nox
Copy link
Member Author

Kr0nox commented Jan 22, 2024

But it gets mentioned when starting the CLI in this message

LanguageLoader - Available languages: '[C/C++ Scanner [basic markup], C/C++ Parser, C# 6 Parser, EMF metamodel, EMF models (dynamically created token set), Go Parser, Javac based AST plugin, Kotlin Parser, LLVMIR Parser, Python3 Parser, R Parser, Rust Language Module, Scala parser, SchemeR4RS Parser [basic markup], SCXML (Statechart XML), Swift Parser, Text Parser (naive), Typescript Parser]

But i can still change it to JS if you want that

@tsaglam
Copy link
Member

tsaglam commented Jan 22, 2024

I think I may have misunderstood something, let's discuss it tomorrow, that is probably easier. :D

@Kr0nox Kr0nox requested a review from TwoOfTwelve January 23, 2024 17:01
Copy link
Member

@tsaglam tsaglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor issue.

languages/javascript/pom.xml Outdated Show resolved Hide resolved
languages/javascript/pom.xml Outdated Show resolved Hide resolved
@Kr0nox Kr0nox requested a review from tsaglam January 25, 2024 15:55
@tsaglam tsaglam merged commit ba44b83 into develop Jan 26, 2024
8 checks passed
@tsaglam tsaglam deleted the feature/js-lang branch January 26, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants