-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JavaScript language module #1494
Conversation
The Language Loader currently uses the |
I would say this is an internal detail that is not important for users. So it is fine when it says javascript for now... |
But it gets mentioned when starting the CLI in this message
But i can still change it to JS if you want that |
I think I may have misunderstood something, let's discuss it tomorrow, that is probably easier. :D |
languages/javascript/src/main/java/de/jplag/javascript/JavaScriptLanguage.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor issue.
Adds a language module for javascript.
It just extends TypeScript, since every typescript keyword is also a javascript keyword.
I moved the js specific tests from the ts language module to the js language module