Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont show cluster graphs on too many members #1510

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Jan 25, 2024

When a cluster has too many members graph drawing can become very slow and also visually very hard to distinguish, since for example the circles start intersecting.
Because of this cluster graphics only get shown up to a certain member treshhold and a warning is displayed

@Kr0nox Kr0nox requested review from tsaglam and sebinside January 25, 2024 19:14
@Kr0nox Kr0nox changed the title Dont show cluste graphs on too many members Dont show cluster graphs on too many members Jan 25, 2024
Copy link

Quality Gate Passed Quality Gate passed for 'JPlag Report Viewer'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Kr0nox Kr0nox added the report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies label Jan 25, 2024
@tsaglam
Copy link
Member

tsaglam commented Jan 26, 2024

The following image shows what caused us to create this PR... 😄

image

@sebinside sebinside merged commit 757820d into develop Jan 29, 2024
16 checks passed
@sebinside sebinside deleted the report-viewar/max-cluster-members branch January 29, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants