Added the option to specify a result file with --move VIEW #2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsaglam
added
enhancement
|
tsaglam
requested changes
Dec 3, 2024
Comment on lines
+56
to
+57
| @Option(names = {"-M", | ||
| "--mode"}, description = "The mode of JPlag. If VIEW is chosen, you can specify a result file to display with either the positional argument, '--new', '--old' or '-r'. Make sure to only specify one if you do that. One of: ${COMPLETION-CANDIDATES} (default: ${DEFAULT_VALUE})") |
There was a problem hiding this comment.
I was wondering whether we should simplify this and not tell the users that there are multiple options. Just document one, but leave the functionality for all others in.
| @@ -29,6 +30,7 @@ | |||
| public class CliInputHandler { | |||
| private static final String OPTION_LIST_HEADING = "Parameter descriptions: "; | |||
|
|
|||
| private static final String AMBIGUOUS_VIEW_FILE = "There are multiple files selected for '--mode VIEW', Please make sure to only specify one."; | |||
There was a problem hiding this comment.
Suggested change
| private static final String AMBIGUOUS_VIEW_FILE = "There are multiple files selected for '--mode VIEW', Please make sure to only specify one."; | |
| private static final String AMBIGUOUS_VIEW_FILE = "There are multiple files specified for '--mode VIEW', please make sure only to specify one."; |
| validOptions.addAll(List.of(this.options.newDirectories)); | ||
| validOptions.addAll(List.of(this.options.oldDirectories)); | ||
|
|
||
| if (this.parseResult.hasMatchedOption('r')) { |
There was a problem hiding this comment.
Magic character. We cannot access the CliOption itself as it is an annotation, right? Then maybe just a constant here.
There was a problem hiding this comment.
It's possible, but really ugly. I'd prefer the constant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the option to specify a result file with
--mode VIEWAllows to specify exactly one file with either the positional argument, --new, --old or -r
The documentation has been adapted in the CLI and in the README