Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update org.glassfish.jaxb:codemodel from 3.0.2 to 4.0.5 and fix break change. #275

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jxfzzzt
Copy link

@jxfzzzt jxfzzzt commented Dec 12, 2024

update org.glassfish.jaxb:codemodel from 3.0.2 to 4.0.5 and fix break change.

@jxfzzzt
Copy link
Author

jxfzzzt commented Dec 12, 2024

@vruusmann

@vruusmann
Copy link
Member

Why is this change necessary now?

I'm planning to upgrade Jakarta XML Binding libraries (jakarta.xml.bind.* classes) from 3.X to 4.X in the upcoming JPMML-Evaluator 1.7.X development branch. It seems to me that around the same time, it would be appropriate to upgrade all related GlassFish Metro dependencies as well, including the GlassFish Codemodel dependency.

@jxfzzzt
Copy link
Author

jxfzzzt commented Dec 13, 2024

Thank you for your suggestion! I agree that upgrading the Jakarta XML Binding libraries at this stage makes sense, and it would also be a good opportunity to update the related dependencies. Regarding org.glassfish.jaxb:codemodel, I want to help developers update their dependencies in a timely manner, introduce potential fixes and new features, and address any breaking change issues.

@vruusmann
Copy link
Member

Regarding org.glassfish.jaxb:codemodel ...

There is also the Java version dimension that must be taken into account.

For example, Jakarta XML Binding 3.X is Java 8 compatible, but Jakarta XML Binding 4.X requires Java 11 or newer. I'm afraid the same applies to CodeModel 3.X vs 4.X.

The current JPMML-Evaluator development branch (1.6.X) is targeting Java 8 compatibility. So, it's not possible to have any "upgraded" dependencies in it.

Just can't update the Java requirement between minor versions (eg. JPMML-Evaluator 1.6.8 and 1.6.9). Has to be accompanied by a major version change (eg. JPMML-Evaluator 1.6.8 vs 1.7.0).

Anyway, your request has been noted. Perhaps I can do the major version upgrade over this coming holiday season. The underlying JPMML-Model library is almost there already.

@jxfzzzt
Copy link
Author

jxfzzzt commented Dec 13, 2024

Thank you for the detailed explanation. Upgrading them in the next major version sounds like a good plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants