Skip to content

Commit

Permalink
Refined transitive dependencies
Browse files Browse the repository at this point in the history
The main 'pmml-model' module should import Jakarta XML Binding
and Jackson annotations in order to prevent numerous Java compiler and
Javadoc warnings in downstream projects.

See jpmml/jpmml-evaluator#234
  • Loading branch information
vruusmann committed Feb 18, 2022
1 parent 0810dd7 commit b4eeae8
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 13 deletions.
5 changes: 0 additions & 5 deletions pmml-model-kryo/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,6 @@
<artifactId>pmml-model</artifactId>
</dependency>

<dependency>
<groupId>jakarta.xml.bind</groupId>
<artifactId>jakarta.xml.bind-api</artifactId>
</dependency>

<dependency>
<groupId>com.esotericsoftware</groupId>
<artifactId>kryo</artifactId>
Expand Down
5 changes: 0 additions & 5 deletions pmml-model-moxy/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,6 @@
<artifactId>pmml-model</artifactId>
</dependency>

<dependency>
<groupId>jakarta.xml.bind</groupId>
<artifactId>jakarta.xml.bind-api</artifactId>
</dependency>

<dependency>
<groupId>org.eclipse.persistence</groupId>
<artifactId>org.eclipse.persistence.moxy</artifactId>
Expand Down
6 changes: 5 additions & 1 deletion pmml-model/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,18 @@
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
<scope>provided</scope>
</dependency>

<dependency>
<groupId>jakarta.xml.bind</groupId>
<artifactId>jakarta.xml.bind-api</artifactId>
</dependency>

<dependency>
<groupId>org.eclipse.persistence</groupId>
<artifactId>org.eclipse.persistence.moxy</artifactId>
Expand Down
5 changes: 3 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,8 @@
<version>3.0.1</version>
<exclusions>
<exclusion>
<groupId>*</groupId>
<artifactId>*</artifactId>
<groupId>com.sun.activation</groupId>
<artifactId>jakarta.activation</artifactId>
</exclusion>
</exclusions>
</dependency>
Expand Down Expand Up @@ -202,6 +202,7 @@
<version>3.8.1</version>
<configuration>
<source>1.8</source>
<showWarnings>true</showWarnings>
<target>1.8</target>
</configuration>
</plugin>
Expand Down

0 comments on commit b4eeae8

Please sign in to comment.