Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme should mention missing stuff #3

Closed
sindresorhus opened this issue Apr 16, 2013 · 5 comments
Closed

Readme should mention missing stuff #3

sindresorhus opened this issue Apr 16, 2013 · 5 comments
Labels
enhancement

Comments

@sindresorhus
Copy link

Code comments is not good enough.

Eg:

link (relative link to feed) - will be added in a future version
@jpmonette
Copy link
Owner

Hey @sindresorhus

You are free to make some pull request and suggest some changes if you want. I develop in my free-time when I'm not at work, doing my best to offer something functional. I'll add additional features/tests/in-depth comments when I'll have some available time.

@sindresorhus
Copy link
Author

That's all fine and good, but if you release something incomplete you should at least have the courtesy to say so.

@jpmonette
Copy link
Owner

Sorry my friend, it's the first real project that I release to the public, only trying to contribute and learn more about the open-source community. Still learning Git too. I'm more like a Business Analyst / Product Manager than a developer, but I love discovering new things and collaborating with people when I have the opportunity.

Also, I'm not sure how I am suppose to take your comments. They do bring a point, but for your last one (for example), I didn't omit to mention that it was still a WIP on purpose, out of courtesy. I just didn't think about it. that it might offend someone. Whatever.

@sindresorhus
Copy link
Author

Didn't mean to come off the wrong way. Was just meant as a tip :)

Put todos in the issue tracker instead. Much easier for users to see what's missing and easier for them to fix it for you.

@sindresorhus
Copy link
Author

tumblr_n8810zxmrd1qdlh1io1_400

agates pushed a commit to agates/feed-podcast that referenced this issue Dec 28, 2022
@rigelk
fixing spec inconsitencies with image enclosure and mrss
9516a01 
- adding mandatory attribute to enclosure image, which fixes Chocobozzz#2
- adding missing namespace when using media:thumbnail, which fixes jpmonette#3

1.1.7
Chocobozzz pushed a commit to Chocobozzz/feed that referenced this issue May 10, 2023
@agates @rigelk
Add support for feed generation using the Podcast Namespace (#1)
15b3439 
* add custom fields

* adding torrent enclosure support

* added support for torrent via arrays/objects/MRSS

* added babel support for rest operator and target node 8 (as used in peertube)

* hotfix: adding proper namespaces and better torrent object handling

1.1.4

* adding support for media:group and moving from peerLink to more complete media:content

1.1.5

* adding support for media:thumbnail

1.1.6

* fixing spec inconsitencies with image enclosure and mrss

- adding mandatory attribute to enclosure image, which fixes #2
- adding missing namespace when using media:thumbnail, which fixes jpmonette#3

1.1.7

* (fix) increment package version

* (mrss) implement additional properties in the item scope for jpmonette#10

- media:categories
- media:community
  - media:statistics
  - media:starRating
- media:keywords
- media:embed
- media:player
- media:subTitle

* (lint) reformatting code for readability

using prettier

* support rich group properties, fix peerLink

BREAKING: torrent was considered as media:content instead of the specified
media:peerLink

resolves jpmonette#10

1.1.9

* (fix) increment package version

* (fix) hash property

* (fix) deal with empty category value

1.1.11

* Update babel/jest

* Add initial podcast namespace support

* Change package for test publishing on NPM

* Re-add content namespace

* 1.2.2

* Fix itunes:image to use href attribute on podcast

* 1.2.3

* Replace title attribute with optional height

Title was mostly meaningless and height is much more obvious while still optional.

* 1.3.0

* Update gitignore for intellij/webstorm

* Add base .idea project files

* 1.4.0

* Add managingEditor, webMaster, itunes:owner

* Add socialInteract, medium

* Update dependencies

* Start version 1.5.0

* Add support for podcast:liveItem and experimental podcast:tracker

* 1.5.1

* Add title attribute to alternateEnclosure

* 1.5.2

* Add podcast:locked tag

* Add experimental podcast:categories on channel and items

* 1.6.0

* Don't generate categories with empty list

* 1.6.1

* Initial commit for podcast feeds using The Podcast Namespace

* Remove old JS files

* Add support for custom tags not built in

* Fix person/locked/explicit

* Version 6.1.1 for packaging changes

* Update sanitized attributes

* Version 6.1.2

* Revert package.json for upstream merge

* Remove .idea folder

* Remove old package-lock.json

* Remove extra files

* Remove .idea folder

* Remove old package-lock.json

* Remove extra files

* alternateEnclosure language attribute should be "lang"

* alternateEnclosure language attribute should be "lang"

* Add support for custom XMLNS definitions

* Add STUN server listing for podcast feeds, add trackers to channel

---------

Co-authored-by: Rigel Kent <sendmemail@rigelk.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sindresorhus @jpmonette