modernize browser_check: refactor chrome-test.js -> browser-test.js as per jupyterlab core
#106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s` as per jupyterlab core
|
|
…twice - I basically just had to twiddle the traitlets until the import, calling, and config syntax/semantics acheived the holy alignment. Took me 6 hours - I still don't fully undertand the root cause of BrowserApp being run twice w.r.t. the underlying libs (ie `jupyter_server` and maybe also `traitlets`), but I do understand why it was causing stochastic CI failures, and I also undertand the proximal cause of the bug in this project's own codebase - Essentially, `BrowserApp.launch_instance()` was not only getting called twice, but getting called twice in instant succession; according to the log timestamps, the two `.launch_instance` calls were only about ~.005 s apart. This caused frequent crashes of the `yarn add playwright` cmd that `BrowserApp` launches as a subprocess, and could apparently also cause issues during the browser_check run itself. Possibility: the browser_check bugs may have been caused by clashes between the two identical playwright instances trying to lock the exact same resources on the exact same browser at nearly the exact same time - I'll start by opening a issue in `jupyter_server` and then maybe also `traitlets`
telamonian
force-pushed
the
modernize-browser-check
branch
from
ce4b117 to
6647358
Compare
telamonian
force-pushed
the
modernize-browser-check
branch
from
1d0a184 to
605e121
Compare
- too heavy, don't actually need while we have just the one typescript package - waaaay too big, waaaay too many subdeps; by itself, it added **82 Mb** to `node_modules` along with hundreds of new packages via its bezoar of dependencies
telamonian
force-pushed
the
modernize-browser-check
branch
from
605e121 to
33178d9
Compare
|
Okay, that was genuinely awful. But its fixed now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the browser_check CI to match recent changes made to
jupyterlab.browser_check. Hopefully this will also make that CI less flaky