Skip to content

Commit

Permalink
Add modular directory to targetLocations checked by typecheck (#2470)
Browse files Browse the repository at this point in the history
* Add modular directory to targetLocations checked by typecheck

* ignore create-react-app template folder when linting

* fix import in create-react-app template
  • Loading branch information
ImmanuelBaskaran authored Oct 12, 2023
1 parent 71e3f5d commit a4fb17a
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .changeset/rich-snakes-drum.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'modular-scripts': patch
---

Add modular directory to targetLocations checked by typecheck
1 change: 1 addition & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ module.exports = {
'**/*.test.*',
'**/__tests__/**',
'**/modular-template-app/**',
'**/create-modular-react-app/template/**',
'**/modular-template-view/**',
'**/modular-template-esm-view/**',
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
// allows you to do things like:
// expect(element).toHaveTextContent(/react/i)
// learn more: https://github.com/testing-library/jest-dom
import '@testing-library/jest-dom/extend-expect';
import '@testing-library/jest-dom';
2 changes: 1 addition & 1 deletion packages/modular-scripts/src/typecheck.ts
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ async function typecheck(
'typecheck',
);

const targetLocations: string[] = [];
const targetLocations: string[] = ['modular'];
for (const [pkgName, pkg] of workspaceMap) {
if (modularTargets.includes(pkgName)) {
targetLocations.push(pkg.location);
Expand Down

0 comments on commit a4fb17a

Please sign in to comment.