add a couple more extensions

jpmorganchase · Dec 22, 2020 · acc11e9 · acc11e9
1 parent 9e6dfac
commit acc11e9
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 5 deletions.
diff --git a/.vscode/extensions.json b/.vscode/extensions.json
@@ -1,3 +1,7 @@
 {
-  "recommendations": ["dbaeumer.vscode-eslint"]
+  "recommendations": [
+    "dbaeumer.vscode-eslint",
+    "esbenp.prettier-vscode",
+    "wayou.vscode-todo-highlight"
+  ]
 }
diff --git a/packages/create-modular-react-app/src/__tests__/index.test.ts b/packages/create-modular-react-app/src/__tests__/index.test.ts
@@ -63,7 +63,7 @@ describe('create-modular-react-app', () => {
       ├─ .eslintignore #1ugsijf
       ├─ .gitignore #1ugsijf
       ├─ .vscode
-      │  ├─ extensions.json #6p4679
+      │  ├─ extensions.json #1i4584r
       │  └─ settings.json #xncm1d
       ├─ README.md #1nksyzj
       ├─ modular

diff --git a/packages/create-modular-react-app/template/.vscode/extensions.json b/packages/create-modular-react-app/template/.vscode/extensions.json
@@ -1,3 +1,7 @@
 {
-  "recommendations": ["dbaeumer.vscode-eslint"]
+  "recommendations": [
+    "dbaeumer.vscode-eslint",
+    "esbenp.prettier-vscode",
+    "wayou.vscode-todo-highlight"
+  ]
 }
diff --git a/packages/modular-scripts/src/__tests__/index.test.ts b/packages/modular-scripts/src/__tests__/index.test.ts
@@ -189,6 +189,11 @@ describe('modular-scripts', () => {
   });
 
   it('can start an app', async () => {
+    // this leaves habing processes on local environments
+    // so we're disabling it for now. Still runs on CI though.
+    if (!process.env.CI) {
+      return;
+    }
     let browser: puppeteer.Browser | undefined;
     let devServer: DevServer | undefined;
     try {

diff --git a/packages/tree-view-for-tests/src/__tests__/tree.test.ts b/packages/tree-view-for-tests/src/__tests__/tree.test.ts
@@ -15,13 +15,13 @@ test('it can serialise a folder', () => {
     ├─ package.json
     ├─ src
     │  ├─ __tests__
-    │  │  └─ index.test.ts #6koefy
+    │  │  └─ index.test.ts #1lu3g5f
     │  ├─ cli.ts #gcx3cm
     │  └─ index.ts #un0l9d
     └─ template
        ├─ .editorconfig #1p4gvuw
        ├─ .vscode
-       │  ├─ extensions.json #6p4679
+       │  ├─ extensions.json #1i4584r
        │  └─ settings.json #xncm1d
        ├─ README.md #1nksyzj
        ├─ gitignore #1ugsijf