Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using rollup directly for our builds #3894

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

joshwooding
Copy link
Contributor

@joshwooding joshwooding commented Jul 25, 2024

Impact on dependencies:
image

Impact on build times: ~10s

Impact on security alerts:

Copy link

vercel bot commented Jul 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 10:57am

Copy link

changeset-bot bot commented Jul 25, 2024

⚠️ No Changeset found

Latest commit: 0fce8c7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshwooding
Copy link
Contributor Author

/release-pr

Copy link
Contributor

🫰✨ Thanks @joshwooding! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @salt-ds/core@0.0.0-snapshot-20240725145339
yarn add @salt-ds/countries@0.0.0-snapshot-20240725145339
yarn add @salt-ds/data-grid@0.0.0-snapshot-20240725145339
yarn add @salt-ds/lab@0.0.0-snapshot-20240725145339
yarn add @salt-ds/theme@0.0.0-snapshot-20240725145339

@joshwooding joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jul 26, 2024
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jul 26, 2024
@joshwooding
Copy link
Contributor Author

/release-pr

Copy link
Contributor

🫰✨ Thanks @joshwooding! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @salt-ds/ag-grid-theme@0.0.0-snapshot-20240726124318
yarn add @salt-ds/core@0.0.0-snapshot-20240726124318
yarn add @salt-ds/countries@0.0.0-snapshot-20240726124318
yarn add @salt-ds/data-grid@0.0.0-snapshot-20240726124318
yarn add @salt-ds/icons@0.0.0-snapshot-20240726124318
yarn add @salt-ds/lab@0.0.0-snapshot-20240726124318
yarn add @salt-ds/styles@0.0.0-snapshot-20240726124318
yarn add @salt-ds/theme@0.0.0-snapshot-20240726124318
yarn add @salt-ds/window@0.0.0-snapshot-20240726124318

@joshwooding
Copy link
Contributor Author

/release-pr

Copy link
Contributor

🫰✨ Thanks @joshwooding! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @salt-ds/ag-grid-theme@0.0.0-snapshot-20241024151254
yarn add @salt-ds/core@0.0.0-snapshot-20241024151254
yarn add @salt-ds/countries@0.0.0-snapshot-20241024151254
yarn add @salt-ds/data-grid@0.0.0-snapshot-20241024151254
yarn add @salt-ds/lab@0.0.0-snapshot-20241024151254

@joshwooding
Copy link
Contributor Author

/release-pr

Copy link
Contributor

🫰✨ Thanks @joshwooding! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @salt-ds/ag-grid-theme@0.0.0-snapshot-20241024230957
yarn add @salt-ds/core@0.0.0-snapshot-20241024230957
yarn add @salt-ds/countries@0.0.0-snapshot-20241024230957
yarn add @salt-ds/data-grid@0.0.0-snapshot-20241024230957
yarn add @salt-ds/lab@0.0.0-snapshot-20241024230957

@joshwooding joshwooding marked this pull request as ready for review October 28, 2024 12:01
@joshwooding joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Oct 28, 2024
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Oct 28, 2024
@joshwooding joshwooding merged commit 218034c into main Oct 28, 2024
16 checks passed
@joshwooding joshwooding deleted the remove-modular branch October 28, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants