-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static list component #3975
Static list component #3975
Conversation
🦋 Changeset detectedLatest commit: 1754553 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@ThusharaJ07 is attempting to deploy a commit to the FED Team Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sharing Design review for reference. (Currently going through 3rd round of reviews) |
@ThusharaJ07, please remove the "Reference", "Requirements", And "Helpful" sections from Accessibility. For now let's keep Keyboard Interactions only as we do in most of the components.Thank you! |
); | ||
|
||
export const Multiple = (): ReactElement => { | ||
const [listArray, setListArray] = useState([ListItem, ListItem]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't representative. This example needs updating to not store the JSX in an array
</Text> | ||
</StackLayout> | ||
</StaticListItemContent> | ||
<Button variant="secondary" aria-label={"icon"}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update these aria-labels in this example
Co-authored-by: Josh Wooding <12938082+joshwooding@users.noreply.github.com>
Co-authored-by: Josh Wooding <12938082+joshwooding@users.noreply.github.com>
$ref: ./#/data | ||
--- | ||
|
||
<LivePreviewControls> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Design guidance needs to be reviewed
Closing to carry on in the repo's duplicate |
No description provided.