Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small improvements #161

Merged
merged 10 commits into from
Jan 11, 2022
Merged

Small improvements #161

merged 10 commits into from
Jan 11, 2022

Conversation

jpquast
Copy link
Owner

@jpquast jpquast commented Nov 5, 2021

No description provided.

@jpquast
Change first colour in qc_cvs
03cb0e9
@jpquast
Add argument to create_structure_contact_map
1860764
@jpquast
Improve create_structure_contact_map
43993b7 
Add parallel_create_structure_contact_map function
@jpquast
Fix auth_seq_id bug
5e6097b 
auth_seq_id was handled as a numeric value even though it should be character. This was fixed in all functions using it.
@jpquast jpquast added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Nov 5, 2021
@jpquast jpquast requested a review from dschust-r November 5, 2021 15:21
@jpquast
Bug fix
882629b
@jpquast
Improve error handling fetching
9fa96a5 
Improved the error handling of try_query. It now returns the error as a character vector instead of NULL. This can be used in the parent function to indicated which IDs were not fetched correctly and why.
@jpquast
Bug fixes and improvements
9202964
dschust-r
dschust-r requested changes Nov 18, 2021
View reviewed changes
Copy link
Collaborator

@dschust-r dschust-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some small comments

@jpquast
Fix proDA names
140b760
@jpquast
Bump version
4b80af2 
Bump version and small documentation updates
@jpquast jpquast requested a review from dschust-r December 20, 2021 15:48
dschust-r
dschust-r requested changes Jan 3, 2022
View reviewed changes
Copy link
Collaborator

@dschust-r dschust-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added only minor comments, otherwise this LGTM!
Do you think we should recommend citation of our paper in the README explicitly? Now we just mention it - I guess that would be good (?)

@jpquast jpquast requested a review from dschust-r January 11, 2022 11:33
dschust-r
dschust-r approved these changes Jan 11, 2022
View reviewed changes
Copy link
Collaborator

@dschust-r dschust-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jpquast jpquast merged commit bd65a55 into master Jan 11, 2022
@jpquast jpquast mentioned this pull request Jan 11, 2022
Closed
@jpquast jpquast deleted the Small-improvements branch March 9, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschust-r dschust-r dschust-r approved these changes

Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpquast @dschust-r