Fetch uniprot 252 #253
Closed
Fetch uniprot 252 #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i set the the default of silent in try_query to TRUE, not sure if we should keep it like this |
|
just saw that the test failed - will let you know when i fixed it |
|
This has been fixed in #250. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #252 (hopefully)
i added more verbos error messages and implemented a retry_delay (can be helpful in case UniProt API has rate limits, reduced server load)
plus, its now possible to pass the timeout/max_tries parameters from the fetch_uniprot function to try_query
i test on fetch_uniprot_proteome(9606) and it was usually working after the second attempt - but would be great if you test it as well