feat: add Engine::load_from_bytes() #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cm-ayf
force-pushed
the
feat/load-from-bytes
branch
from
208459d to
1e25079
Compare
cm-ayf
force-pushed
the
feat/load-from-bytes
branch
from
1e25079 to
2add8b2
Compare
phenylshima
reviewed
Jan 27, 2025
Comment on lines
+166
to
+171
| /// Load `.htsvoice` file content as [`Voice`]. | ||
| #[cfg(feature = "htsvoice")] | ||
| pub fn load_htsvoice_from_bytes(bytes: &[u8]) -> Result<Voice, ModelError> { | ||
| Ok(parser::parse_htsvoice(bytes)?) | ||
| } | ||
|
|
There was a problem hiding this comment.
この辺，データでロードできるならload_htsvoice_fileのstd::fs::readをEngine::loadに書くべきような気がします．
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WASM で使いたそうな人がいたので．