Fix: use github.com instead of nodeload.github.com for downloading zips #17
+2,752
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update outdated dependencies to fix "npm audit" critical issues
- avoid unnecessary rename or copy when unzipping files
This also avoids getting "error: EXDEV" when trying to rename
between devices. In other words, with respect to the test cases,
trying to rename the relative './$TIMESTAMP/' directory to
'/tmp/test-github-download/1/', for example, will fail with EXDEV
if `/tmp` is a separate device mount on the machine.
- dependency changes:
- update request@{2.12.0 -> 2.88.1}
- add strip-dirs@^3.0.0
- dev dependency changes:
- update mocha@{2.x -> 8.x}
- update standard@{5.x -> 11.x}
|
Updated the travis.yml to use
|
1 task
|
A friend of mine was experiencing this issue as well when using Truffle. I had no issues with however he was getting SSH issues which preventing truffle from working |
|
plz merge, this is a fix for the truffle unbox problem I'm having still |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be an unavoidable SSL issue with downloading repo ZIPs from https://nodeload.github.com.
I've modified the code to instead download straight from
https://github.com/$USER/$REPO/archive/$TAG.zip(this uses the same link format as the "Download ZIP" on the website itself).This more importantly was causing issues upstream with running
truffle init(see issue).The only other changes where making
extractZipunzip directly to the target directory, and updating dependencies which were causingnpm auditissues.Please feel free to let me know if there should be any additional changes made to this PR. Or if anything needs any clarification.
Thanks!
dependency changes:
dev dependency changes: