Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug-fix: download files across devices now works #6

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

itsthatguy
Copy link

fs.rename does not work across devices.

  • Implementing mv to replace fs.rename.

@jprichardson
Copy link
Owner

A few things:

  1. Please change the require alignment back to the way it was.
  2. Please remove the version bump.
  3. Please remove the mv dependency and use fs.move from fs-extra. (fs.move is mv)

That should do it. Thanks.

@itsthatguy
Copy link
Author

re: 1. Feel free to change that back, I'm not in an ideal environment to make that change (mobile)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants