Add non-dev time comparisons #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe the most nitpicky comment ever, but, I would suggest swapping the two donut charts so that the total hours chart is on the left. Reason being that the second chart is sort of a drill-down into a component of the other chart (non-dev time) and reading left to right you'd expect them to get more granular as you move to the right. |
| @@ -67,6 +67,7 @@ Meteor.publish 'tickets', (selectedSquad) -> | |||
| priority: issue.fields.priority.name | |||
| labels: issue.fields.labels | |||
| status: issue.fields.status.name | |||
| timespent: issue.fields.timespent/3600 | |||
There was a problem hiding this comment.
I'd like to see if we can use moment to do some nice formatting here. At the very least some rounding would be nice.
|
Made a few comments - my brain is kind of fried right now though, so I'll take another look after you incorporate these changes. There's no rush on this since it's already deployed. |
added 12 commits
December 16, 2015 17:02
jprince
force-pushed
the
mct-add-non-dev-time
branch
from
2ed32d2
to
20e19c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull timespent from the JIRA API for each ticket
Show a pie chart of non-dev time compared to the different tickets
Show a pie chart of non-dev time, feature time, and bug time
Show a list of non-dev tickets and information about them (including time spent)