Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Length modes #88

Merged
merged 22 commits into from
Jan 27, 2024
Merged

Length modes #88

merged 22 commits into from
Jan 27, 2024

Conversation

jprochazk
Copy link
Owner

@jprochazk jprochazk commented Jan 21, 2024 •
edited
Loading

@jprochazk jprochazk marked this pull request as draft January 21, 2024 18:35
@jprochazk jprochazk mentioned this pull request Jan 21, 2024
Closed
4 tasks
@dpytaylo dpytaylo mentioned this pull request Jan 21, 2024
Closed
@jprochazk jprochazk marked this pull request as ready for review January 27, 2024 09:44
@jprochazk
Copy link
Owner Author

half is causing way too many issues. Don't want to bump the msrv, so I'm just going to remove the benchmarks and criterion.

aumetra
aumetra approved these changes Jan 27, 2024
View reviewed changes
Copy link
Contributor

@aumetra aumetra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me

garde/benches/validation.rs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

benchmarks are over 😔

@jprochazk jprochazk merged commit 676bfb9 into main Jan 27, 2024
5 checks passed
@jprochazk
Copy link
Owner Author

Released in v0.18

@LeoniePhiline LeoniePhiline mentioned this pull request Feb 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aumetra aumetra aumetra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rework string length rules Feature request: UTF-16 code units length validator
2 participants
@jprochazk @aumetra