Fix ignore identifiers starting with '@'

[norio-nomura]

isIdentifier always returned false.

[jpsim]

Thanks!

[norio-nomura]

🙏

[jpsim]

Hey @norio-nomura, do you remember why you did this? In realm/SwiftLint#608 you said that otherwise Swift 2.2 tests failed, but I can't reproduce that, and now we just discovered that this introduced a regression in jazzy: realm/jazzy#530

I obviously don't want to revert this if it will cause other regressions, but I don't know what those are 😄

[jpsim]

Never mind, I can reproduce the failures... I'll have to see how to fix one bug without reintroducing the other!

[norio-nomura]

Sorry for missing documentation.
That fixes "Stop searching comment on identifier not having @ prefix." to as is.
Before fix, that never stop searching on any identifiers.

[norio-nomura]

@jpsim I want to see the regression of realm/jazzy#530. Where can I check that?

[jpsim]

You can see the diff to jazzy's generated output here: https://github.com/realm/jazzy-integration-specs/compare/jp-render-swift-declarations-in-objc

The regression is the lost extension documentation in Moya.

I have some ideas on how to fix this for both SwiftLint and jazzy but it's a bit complex. It involves checking the structure depth of the previous documentation comment compared to the documented declaration, and validating the structures in between.

[norio-nomura]

Thanks for information.
I see following.

/// Extension for processing raw NSData generated by network access.
@available(*, deprecated, message="This will be removed when ReactiveCocoa 4 becomes final. Please visit https://github.com/Moya/Moya/issues/298 for more information.")
public extension RACSignal {

Now I know the reason why you added checking .Extension on 385115a#diff-c40f53a6b61685c6741ff5753303e59aR324.

I think we need to detect attributes much smarter.
I'll have a look about another approach on detecting attribute.

[norio-nomura]

I'll have a look about another approach on detecting attribute.

That seems difficult.
How about separating getDocumentationCommentBody() into SwiftLint version and jazzy version?
On jazzy only version, we can use approach of #142 (comment)

[norio-nomura]

I came up with another idea that use parent structure's body offset or sibling structure's end offset for limiting search doc comment.
I'll try to implement that.

[jpsim]

I came up with another idea that use parent structure's body offset or sibling structure's end offset for limiting search doc comment.

Yeah, this is along the lines of what I meant in #197 (comment). There's no rush for this, if you don't get around to doing this, I'll probably find time at some point, just to get realm/jazzy#530 out.

[norio-nomura]

It seems my fix is not needed.
Thanks!

[jpsim]

yeah I fixed this in #95, sorry for not updating this thread when that happened! 😬