Introduce UncheckedSendable type for wrapping non-sendable types
#806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpsim
approved these changes
Feb 27, 2024
Signed-off-by: Marcos Griselli <marcosg@lyft.com>
|
Done! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #805
Introduce an
UncheckedSendabletype for wrapping non-sendable types in a@Sendablecontext.More context on why unsafe pointer types are no longer Sendable: https://forums.swift.org/t/unsafepointer-sendable-should-be-revoked/51926
The change was merged some time ago and only the warning is new in Xcode 15.3 betas so the behavior shouldn't be affected by this change.
extension UnsafeMutablePointer: @unchecked Sendable {}would've also silenced the warning but would go against the points made in the forums discussion. Keeping theUncheckedSendablewrapper forces to acknowledge the context and solution.Open to try different approaches but this is the one I'm familiar with.