Use more effectively that Node is an enum
#105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change parameter type of `ScalarConstructible.construct(from:)` from `Node` to `Node.Scalar` * Change `Constructor`: * Split `Map` type into `ScalarMap`, `MappingMap` and `SequenceMap` * Split `defaultMap` static property into `defaultScalarMap`, `defaultMappingMap` and `defaultSequenceMap` * Change `init(_:)` to `init(_:_:_:)`
This reverts commit bc25555.
norio-nomura
force-pushed
the
nn-change-ScalarConstructible
branch
from
b7435be
to
fd28473
Compare
norio-nomura
force-pushed
the
nn-change-ScalarConstructible
branch
from
8278d2d
to
e4a0b96
Compare
jpsim
reviewed
Feb 17, 2018
CHANGELOG.md
Outdated
| @@ -2,7 +2,17 @@ | |||
|
|
|||
| ##### Breaking | |||
|
|
|||
| * None. | |||
| * Some APIs are changed related to `ScalarConstructible` | |||
[skip ci]
|
Thanks for reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScalarConstructible.construct(from:)fromNodetoNode.ScalarConstructor:Maptype intoScalarMap,MappingMapandSequenceMapdefaultMapstatic property intodefaultScalarMap,defaultMappingMapanddefaultSequenceMapinit(_:)toinit(_:_:_:)