Prevent crash when decoding case of malformed sequence of strings in a mapping #95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a case of malformed input that crashed the Decoder when using a
Codable
struct.Given a struct like this:
data like this would decode correctly:
but data like this would crash:
It seems to be because it's looking for a mapping but not finding one and that case is not handled, so the subsequent assertion fails. This PR avoids the crash by returning nil instead.
I'm not sure this is the right way to handle it (or even a good way), but at least it prevents the crash in my use case.
Thanks for creating this pod!