Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parse quoted values as strings #117

Merged
merged 1 commit into from
Mar 29, 2018
Merged

Fix parse quoted values as strings #117

merged 1 commit into from
Mar 29, 2018

Conversation

norio-nomura
Copy link
Collaborator

Fix #116

@norio-nomura norio-nomura changed the title Parse quoted values as strings Fix parse quoted values as strings Mar 27, 2018
keith
keith approved these changes Mar 29, 2018
View reviewed changes
Copy link
Contributor

@keith keith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome fix! Would be great to have a release with this!

Sources/Yams/Parser.swift
@@ -287,9 +287,8 @@ private class Event {
return Node.Scalar.Style(rawValue: event.data.scalar.style.rawValue)!
}
var scalarTag: String? {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can return a String now

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can't since string(from:) still returns String?

jpsim
jpsim approved these changes Mar 29, 2018
View reviewed changes
Copy link
Owner

@jpsim jpsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I'll be cutting a release after merging this.

@jpsim jpsim merged commit 338a1a0 into master Mar 29, 2018
@jpsim jpsim deleted the nn-fix-116 branch March 29, 2018 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpsim jpsim jpsim approved these changes

@keith keith keith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@norio-nomura @keith @jpsim @yonaskolb