Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set DYLIB_COMPATIBILITY_VERSION and DYLIB_CURRENT_VERSION in Yams.xcodeproj #132

Merged
merged 1 commit into from
Jul 24, 2018

Conversation

norio-nomura
Copy link
Collaborator

@norio-nomura norio-nomura commented Jul 20, 2018

Since CocoaPods installs dependencies with setting DYLIB_*_VERSION as 1, DYLIB_*_VERSION did not match between Yams.framework built with own Yams.xcodeproj and installed by CocoaPods.
This change matches them and would resolve #131.

Since CocoaPods installs dependencies with setting `DYLIB_*_VERSION` as `1`, `DYLIB_*_VERSION` did not match between `Yams.framework` built with own `Yams.xcodeproj` and installed by CocoaPods.
This change matches them and resolves #131.
Copy link
Owner

@jpsim jpsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to remember to bump these when we change version numbers?

@norio-nomura
Copy link
Collaborator Author

These version numbers are used for binary compatibility by dyld.
There is no reason to update them until Swift provides ABI stability and we start binary distribution.

@jpsim
Copy link
Owner

jpsim commented Jul 21, 2018

Got it 👍

@norio-nomura norio-nomura merged commit 5cedfb1 into master Jul 24, 2018
@norio-nomura norio-nomura deleted the nn-dylib-versions branch July 24, 2018 00:16
davidgovea added a commit to runtrizapps/mixpanel-iphone that referenced this pull request Dec 28, 2020
via setting of DYLIB_CURRENT_VERSION and DYLIB_COMPATIBILITY_VERSION.
Related PRs:
jpsim/Yams#132
SnapKit/SnapKit#646
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When built with Carthage, version is 0.0.0
2 participants