Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_KeyedDecodingContainer and _UnkeyedDecodingContainer did not properly decode null #158

Merged
merged 3 commits into from
Jan 29, 2019

Conversation

norio-nomura
Copy link
Collaborator

Fixes #157

Copy link
Owner

@jpsim jpsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Can we make a yams-1.0-branch branch cut from the 1.0.1 release and apply this and future bugfixes so we don't collect a bunch of fixes along with the breaking changes in master?

@norio-nomura
Copy link
Collaborator Author

Yes, we can.
Which commit should we branch from? c935ba1?

@norio-nomura norio-nomura merged commit e8dd69f into master Jan 29, 2019
@norio-nomura norio-nomura deleted the fix-157 branch January 29, 2019 03:50
@jpsim
Copy link
Owner

jpsim commented Jan 29, 2019

Sure, sounds good. We'll need to pull in the CI changes too if we want to run that branch on CI.

norio-nomura added a commit that referenced this pull request Jan 29, 2019
_KeyedDecodingContainer and _UnkeyedDecodingContainer did not properly decode null
@finestructure
Copy link
Contributor

Thanks a lot for merging in that fix! I don't think there's a release with that, is there?

I'd rather not pull in master instead of tags so I'm wondering if I should tag in a fork. Or do you plan on pushing out a release soon?

@jpsim
Copy link
Owner

jpsim commented Apr 1, 2019

I'll make a 1.0.2 release today with the tip of yams-1.0-branch. master has some breaking changes so we'll want to cut a 2.0 release from that shortly too.

@jpsim
Copy link
Owner

jpsim commented Apr 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants