Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make YAMLDecoder conform to TopLevelDecoder #262

Merged
merged 18 commits into from
Jul 7, 2020

Conversation

jpsim
Copy link
Owner

@jpsim jpsim commented Jul 4, 2020

Addresses #261

For reference: CoreOffice/XMLCoder#132

TODO:

  • Changelog entry
  • Documentation
  • Unit tests

@jpsim jpsim marked this pull request as draft July 4, 2020 01:44
@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2020

Codecov Report

Merging #262 into master will increase coverage by 7.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
+ Coverage   89.89%   96.89%   +7.00%     
==========================================
  Files          14        8       -6     
  Lines        1108      129     -979     
==========================================
- Hits          996      125     -871     
+ Misses        112        4     -108     
Impacted Files Coverage Δ
Sources/Yams/Parser.swift 100.00% <ø> (+4.02%) ⬆️
Sources/Yams/Node.Scalar.swift 100.00% <0.00%> (ø)
Sources/Yams/Node.Mapping.swift
Sources/Yams/String+Yams.swift
Sources/Yams/Constructor.swift
Sources/Yams/Resolver.swift
Sources/Yams/Emitter.swift 100.00% <0.00%> (+5.26%) ⬆️
Sources/Yams/Tag.swift 100.00% <0.00%> (+11.11%) ⬆️
Sources/Yams/Node.swift 100.00% <0.00%> (+16.00%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11bbade...9b6071e. Read the comment docs.

@jpsim jpsim marked this pull request as ready for review July 6, 2020 23:44
@jpsim jpsim merged commit 6e6483a into master Jul 7, 2020
@jpsim jpsim deleted the add-topleveldecoder-conformance branch July 7, 2020 00:54
@MPLew-is MPLew-is mentioned this pull request Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants