respond to breaking change

KC_FNx is deleted. So... - Remove KC_FNx codes. - Provide workaround to save default layer to EEPROM.
jpskenn · Apr 10, 2022 · a8e6980 · a8e6980
1 parent 37c663c
commit a8e6980
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 23 deletions.
diff --git a/keyboards/nora/v1/keymaps/via/keymap.c b/keyboards/nora/v1/keymaps/via/keymap.c
@@ -132,28 +132,35 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
 bool process_record_user(uint16_t keycode, keyrecord_t *record) {
     switch (keycode) {
         case VERSION: // Output firmware info.
-        case KC_FN0:
             if (record->event.pressed) {
                 SEND_STRING (QMK_KEYBOARD ":" QMK_KEYMAP " @ " QMK_VERSION " | " QMK_BUILDDATE);
             }
             return false;
-        case KC_FN1: // Change default ayer --> Write to EEPROM
+        case BASE1: // If "Shift" pressed, Change default ayer --> Write to EEPROM
             if (record->event.pressed) {
-                set_single_persistent_default_layer(_BASE1);
+                if (get_mods() & MOD_MASK_SHIFT) {
+                    set_single_persistent_default_layer(_BASE1);
+                    return false;
+                }
             }
-            return false;
-        case KC_FN2: // Change default ayer --> Write to EEPROM
+            return true;
+        case BASE2: // If "Shift" pressed, Change default ayer --> Write to EEPROM
             if (record->event.pressed) {
-                set_single_persistent_default_layer(_BASE2);
+                if (get_mods() & MOD_MASK_SHIFT) {
+                    set_single_persistent_default_layer(_BASE2);
+                    return false;
+                }
             }
-            return false;
-        case KC_FN3: // Change default ayer --> Write to EEPROM
+            return true;
+        case BASE3: // If "Shift" pressed, Change default ayer --> Write to EEPROM
             if (record->event.pressed) {
-                set_single_persistent_default_layer(_BASE3);
+                if (get_mods() & MOD_MASK_SHIFT) {
+                    set_single_persistent_default_layer(_BASE3);
+                    return false;
+                }
             }
-            return false;
-        case IND_TOG: // Toggle Layer indicator.
-        case KC_FN4:
+            return true;
+        case IND_TOG: // Toggle LED indicator.
             if (record->event.pressed) {
                 is_led_indicator_enabled = !is_led_indicator_enabled;
             }

diff --git a/keyboards/nora/v1/keymaps/via_re/keymap.c b/keyboards/nora/v1/keymaps/via_re/keymap.c
@@ -142,28 +142,35 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
 bool process_record_user(uint16_t keycode, keyrecord_t *record) {
     switch (keycode) {
         case VERSION: // Output firmware info.
-        case KC_FN0:
             if (record->event.pressed) {
                 SEND_STRING (QMK_KEYBOARD ":" QMK_KEYMAP " @ " QMK_VERSION " | " QMK_BUILDDATE);
             }
             return false;
-        case KC_FN1: // Change default ayer --> Write to EEPROM
+        case BASE1: // If "Shift" pressed, Change default ayer --> Write to EEPROM
             if (record->event.pressed) {
-                set_single_persistent_default_layer(_BASE1);
+                if (get_mods() & MOD_MASK_SHIFT) {
+                    set_single_persistent_default_layer(_BASE1);
+                    return false;
+                }
             }
-            return false;
-        case KC_FN2: // Change default ayer --> Write to EEPROM
+            return true;
+        case BASE2: // If "Shift" pressed, Change default ayer --> Write to EEPROM
             if (record->event.pressed) {
-                set_single_persistent_default_layer(_BASE2);
+                if (get_mods() & MOD_MASK_SHIFT) {
+                    set_single_persistent_default_layer(_BASE2);
+                    return false;
+                }
             }
-            return false;
-        case KC_FN3: // Change default ayer --> Write to EEPROM
+            return true;
+        case BASE3: // If "Shift" pressed, Change default ayer --> Write to EEPROM
             if (record->event.pressed) {
-                set_single_persistent_default_layer(_BASE3);
+                if (get_mods() & MOD_MASK_SHIFT) {
+                    set_single_persistent_default_layer(_BASE3);
+                    return false;
+                }
             }
-            return false;
+            return true;
         case IND_TOG: // Toggle LED indicator.
-        case KC_FN4:
             if (record->event.pressed) {
                 is_led_indicator_enabled = !is_led_indicator_enabled;
             }