flask_basicauth.py: add BASIC_AUTH_ALLOW_OPTIONS override flag #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitelists OPTIONS method requests for compatibility with Flask-CORS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CORS requires pre-flight
OPTIONSmethod requests to work without theAuthorizationheader from the browser.Otherwise, the browser will raise CORS errors on calls to any endpoints protected with basic auth, and the requests will not work properly. Here is an example error message from Chrome:
Failed to load https://host:port/api_url: Response for preflight has invalid HTTP status code 401.With the
BASIC_AUTH_ALLOW_OPTIONSconfig option enabled, theOPTIONSrequests are allowed, and Flask-CORS can send back the right response for the browser, so that the endpoints will work with CORS enabled.