Allow hashed passwords #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Locally with python 3.7.3, the old code fails with:
ModuleNotFoundError: No module named 'flask.ext'
I'd like to re-use check_username for hashed passwords.
This avoids needing to store the plain password on the service that's accepting basic auth. It should also avoid problems with direct comparison of passwords leading to information leakage due to variable-time string comparisons.
|
I'll need to come up with a different way to handle this to support python 2.6 and 3.3 |
|
I doubt I'll ever find time to devote to making this work on really old versions of Python. If you drop support for versions past their end-of-life, then this may be useful to bring back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to use simple basic auth for a service, but without storing the plain-text password on the host.
This allows setting a PBKDF2-derived hash value in place of the password, with some optional configuration parameters to choose the algorithm, salt and number of rounds.
I believe this also avoids the variable-time password comparison described in #3 / #21, when configured to use a hashed password.