Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanity check for JImplements #1082

Merged
merged 3 commits into from
Aug 25, 2022
Merged

Conversation

Thrameos
Copy link
Contributor

Report an easy to make error with a less confusing message.

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.62%. Comparing base (faa41f7) to head (c371234).
Report is 291 commits behind head on master.

Files Patch % Lines
jpype/_jproxy.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1082      +/-   ##
==========================================
- Coverage   88.63%   88.62%   -0.02%     
==========================================
  Files         112      112              
  Lines       10235    10247      +12     
  Branches     4012     4012              
==========================================
+ Hits         9072     9081       +9     
- Misses        703      706       +3     
  Partials      460      460              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@marscher marscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marscher marscher merged commit 82a7658 into jpype-project:master Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants