Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are there any errors in the ICU License description in the "decNumber"? #3079

Closed
2020122300003133 opened this issue Mar 26, 2024 · 4 comments · Fixed by #3106
Closed

Are there any errors in the ICU License description in the "decNumber"? #3079

2020122300003133 opened this issue Mar 26, 2024 · 4 comments · Fixed by #3106
Labels

Comments

@2020122300003133
Copy link

https://github.com/jqlang/jq?tab=License-1-ov-file#readme
The "decNumber" of the ICU License listed here is "ICU 1.8.1 and later", is this correct?

I am aware that the following is listed at the end of the "ICU 1.8.1 and later" regulation, but I do not see it listed here.

"All trademarks and registered trademarks mentioned herein are the property of their respective owners."

Wouldn't the correct phrase be "ICU License - ICU 1.8.1 to ICU 57.1" instead of "ICU 1.8.1 and later"?

Best regards,

@2020122300003133
Copy link
Author

https://github.com/jqlang/jq/blob/master/src/decNumber/ICU-license.html
I found the correct License here.

I suggest that the "readme" be modified.

Best regards,

@emanuele6
Copy link
Member

I cannot see what is wrong. src/decNumber/ICU-license.html says "ICU 1.8.1 and later"; and README.md says

jq uses parts of the open source C library "decNumber", which is distributed under ICU License

And the "ICU License" link links to COPYING that says "ICU 1.8.1 and later".

@emanuele6
Copy link
Member

Oh, you are saying COPYING is missing:


--------------------------------------------------------------------------------
All trademarks and registered trademarks mentioned herein are the property of their respective owners.

at the end.

Hmm, that is probably part of the licence, yes. It should be included in COPYING

emanuele6 added a commit to emanuele6/jq-1 that referenced this issue May 1, 2024
Fixes jqlang#3079

Also clarify what files the Kungliga Tekniska Högskolan copyright notice
applies to.
emanuele6 added a commit that referenced this issue May 1, 2024
Fixes #3079

Also clarify what files the Kungliga Tekniska Högskolan copyright notice
applies to.
@2020122300003133
Copy link
Author

I apologize that my explanation was not clear.
And thank you for adding the document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants